Make nested classes explicitly-specifiable and work through some integration issues #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Oct 26, 2024
|
We're going to start with #115 and I'm going to rebase the few needed changes on top. |
We're using the "normal" name now that uses $ for nested classes.
Rather than having the Java-to-Swift translator walking all nested classes itself, provide it with the set of nested classes that should be translated along with the enclosing class. This allows us to be explicit about the naming of nested classes in the config file (where we want to), while still getting the convenience of translating the nested classes automatically for you by default.
…avaType" This is deeply unfortunate, but we need compile-side fixes for nested types named "Type" to work.
DougGregor
force-pushed
the
java2swift-nested-classes
branch
from
a94a5f6 to
968a580
Compare
DougGregor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a follow-on to #115 that improves things in a few ways:
Java2Swift.configto explicitly specify nested classes, or omit them to get them autogenerated. This "moved" the recursion to make it computed by the outer Java2Swift rather than always walking through all nested classes.X.Typealready has a meaning.