Remove high dpi scaling option with Qt6 #357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes Qt-specific high DPI scaling functionality to align with Qt6's built-in automatic DPI scaling. Qt6 natively handles high DPI scaling based on system display settings, making manual per-application scaling adjustments unnecessary.
- Removes the
--scalecommand line option and related parsing logic - Eliminates high DPI support methods from CGuiApplication and CGuiUtility classes
- Updates metrics info display format to remove high DPI status indication
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/swiftguistandard/main.cpp | Removes high DPI screen support initialization call |
| src/swiftdata/main.cpp | Removes high DPI screen support initialization call |
| src/swiftcore/main.cpp | Removes high DPI screen support initialization call |
| src/gui/guiutility.h | Removes high DPI support status method declaration |
| src/gui/guiutility.cpp | Removes high DPI support method and updates metrics info format |
| src/gui/guiapplication.h | Removes scale-related command line options and high DPI methods |
| src/gui/guiapplication.cpp | Removes implementation of high DPI support and scale factor parsing |
| samples/hotkey/main.cpp | Removes high DPI screen support initialization call |
| .github/workflows/build.yml | Changes archive format from .7z to .zip (unrelated to high DPI changes) |
ltoenning
force-pushed
the
high_dpi_scaling
branch
from
f517533 to
932a006
Compare
This removes the --scale command line option. Qt6 seems to have this already integrated to scale according to the nativ display settings: https://doc.qt.io/qt-6.8/highdpi.html Adjusting the scale on a per-application basis is not intended (anymore) according to the documentation. Tested on a (near) high-dpi screen.
ltoenning
force-pushed
the
high_dpi_scaling
branch
from
932a006 to
0c77b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the --scale command line option.
Qt6 seems to have this already integrated to scale according to the native display settings: https://doc.qt.io/qt-6.8/highdpi.html
Adjusting the scale on a per-application basis is not intended (anymore) according to the documentation. Tested on a (near) high-dpi screen.