Skip to content

Prepare for Python 3.14 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025
Merged

Conversation

kddubey
Copy link
Contributor

@kddubey kddubey commented Jul 3, 2025

  • fix Tests fail on Python 3.14b1 #163. tested locally on
     Python 3.14.0b3 (v3.14.0b3:26d485d1225, Jun 17 2025, 12:48:06) [Clang 16.0.0 (clang-1600.0.26.6)] on darwin
    
  • fix strange bug where, sometime after python 3.13.0, inspect.signature(PydanticV1Dataclass) includes self as the first parameter
  • add black formatting to dev setup
  • replace pydantic v1 check w/ simpler one that doesn't require the packaging dependency
  • move demos to demos/

note: i don't think we can add python 3.14 to the test matrix b/c installing pydantic currently doesn't work in 3.14

@kddubey kddubey marked this pull request as draft July 3, 2025 07:26
@kddubey kddubey force-pushed the kddubey/fix-python-314 branch from 12a592c to 05646e4 Compare July 3, 2025 07:50
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.61%. Comparing base (619ee8b) to head (34f9d27).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   94.59%   94.61%   +0.01%     
==========================================
  Files           4        4              
  Lines         722      724       +2     
==========================================
+ Hits          683      685       +2     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kddubey kddubey changed the title Fix #163 Prepare for Python 3.14 Jul 3, 2025
@kddubey kddubey marked this pull request as ready for review July 3, 2025 09:55
@martinjm97 martinjm97 merged commit 7f36ff2 into swansonk14:main Jul 4, 2025
17 checks passed
@martinjm97
Copy link
Collaborator

Thank you again @kddubey! Kyle and I have been under water with life and research! Thank you for keeping the Tap running!

@kddubey kddubey deleted the kddubey/fix-python-314 branch July 4, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on Python 3.14b1
3 participants