Skip to content

Fixed the typing of the function #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

amotzop
Copy link

@amotzop amotzop commented Feb 25, 2025

The current typing mandates that the "tapified" function must accept only one argument (of type InputType, which is anything).
The change makes it so it can accept any number of argument.

@kddubey
Copy link
Contributor

kddubey commented Mar 1, 2025

Pretty sure this is right. In fact, can we remove InputType from tapify completely?

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (f8d477c) to head (3c3ee97).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   94.60%   94.59%   -0.01%     
==========================================
  Files           4        4              
  Lines         723      722       -1     
==========================================
- Hits          684      683       -1     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinjm97
Copy link
Collaborator

Yes, I think that this looks reasonable. After removing InputType and adding testing (if possible), it should be ready to merge.

--Jesse

@amotzop
Copy link
Author

amotzop commented Mar 11, 2025

I'm not sure how to add a test for it.

@Daraan
Copy link

Daraan commented Apr 9, 2025

I've just taken a look at this and it looks fine. I didn't check the workflows but comparing before/after with pyright, pylance, mypy would reveal potential negative changes.

@martinjm97 martinjm97 merged commit 619ee8b into swansonk14:main Apr 9, 2025
11 checks passed
@martinjm97
Copy link
Collaborator

Fair enough. It's small enough that I'll merge. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants