Clean the code, type annotations and update dependencies #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1920983.
…s in typing module
arnaud-ma
commented
Jul 7, 2024
tap/utils.py
Outdated
Comment on lines
34
to
41
| def is_literal_type(tp: type) -> bool: | ||
| """Returns whether the type is a literal type.""" | ||
| return tp is Literal or getattr(tp, "__origin__", None) is Literal | ||
|
|
||
| def get_origin(tp: type) -> type: | ||
| """Same as typing.get_origin but returns the type itself if the origin is None.""" | ||
| origin = typing_get_origin(tp) | ||
| return origin if origin is not None else tp |
There was a problem hiding this comment.
The pieces of code that must be added to remove typing_inspect from dependencies. There is little risk of having to modify it for future versions of python since almost everything is done in the typing module
|
What's the story here? |
|
I apologize for the waste of time. I realized there were too many conflicts with other pull requests. It seems easier to me to make a (much) cleaner one later. The goals remain: update the < 3.8 Python code and add more precise type hints. |
|
I see. Sorry for the conflicts! I think making a few smaller PRs will make it easier to merge! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code must have been added before Python 3.8. We can put this version to good use. These fixes do not modify the runtime in any way.
Changes:
typing.Protocolandtyping.TypedDictinstead of bare dict, callable or typesI think it is possible to go much further in type annotation (e.g. by annotating some methods with *args and **kwargs). But for this, typing-extensions must be added as a dependency.
I thought for a long time that using
from __future__ import annotationsto usedict[str | int, int] | List[str |int]instead ofUnion[Dict[Union[str, int], int], List[Union[str, int]]would be a good idea, but the package itself does not support this syntax so it would only be an additional source of bugs.