Fix Ambiguous Measurement Error in Recipe Converter #852
+713
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed small quantity conversion for vanilla extract, baking powder, and salt - Updated conversion database with correct gram values per teaspoon - Improved ingredient parsing logic for fractions and mixed numbers - Added proper imperial unit conversion system - Enhanced error handling and user feedback
Thanks for creating a PR for your Issue!
|
supriya46788
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the "Ambiguous Measurement" error that was occurring when converting recipes with small quantities. Small ingredients like vanilla extract, baking powder, and salt were showing 0g instead of proper gram values.
Changes Made
Testing Verified
✅ Vanilla extract: 1 tsp → 4.2g (was 0g)
✅ Baking powder: 1 tsp → 4.8g (was 0g)
✅ Salt: 1/4 tsp → 1.4g (was 0g)
✅ All other ingredients maintain correct conversions
Files Modified
assets/js/convert.js- Complete conversion logic overhaulCloses #823
Screenshot:
BEFORE:
https://github.com/user-attachments/assets/363fc1bf-84cc-49b8-8b71-f12ce696f099
AFTER:
https://github.com/user-attachments/assets/363be0e0-7fd6-43f5-9cad-dadb305f3319