Skip to content

feat: expose systemMemoryInfo API for main worker #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024

Conversation

laktek
Copy link
Contributor

@laktek laktek commented May 10, 2024

Adding it to the EdgeRuntime namespace instead of the Deno namespace to prevent accidentally exposing it in user workers. Also, we are implementing a customized version of it for performance reasons (ie. only support in Linux via sysinfo)

@laktek laktek requested review from nyannyacha May 10, 2024 02:04
Adding it to EdgeRuntime namespace instead of Deno namespace, to prevent
accidentally exposing it in user workers. Also, we are implementing customized version of it for performance reasons (ie. only support Linux
via sysinfo)
@laktek laktek force-pushed the expose-system-memory-info branch from 5d24585 to 9c877e5 Compare May 10, 2024 05:34
Copy link
Contributor

@nyannyacha nyannyacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😋

@laktek laktek merged commit ac5e2d6 into main May 10, 2024
3 checks passed
@laktek laktek deleted the expose-system-memory-info branch May 10, 2024 05:48
Copy link

🎉 This PR is included in version 1.49.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

nyannyacha pushed a commit to nyannyacha/edge-runtime that referenced this pull request May 12, 2024
Adding it to EdgeRuntime namespace instead of Deno namespace, to prevent
accidentally exposing it in user workers. Also, we are implementing customized version of it for performance reasons (ie. only support Linux
via sysinfo)
nyannyacha pushed a commit to nyannyacha/edge-runtime that referenced this pull request May 13, 2024
Adding it to EdgeRuntime namespace instead of Deno namespace, to prevent
accidentally exposing it in user workers. Also, we are implementing customized version of it for performance reasons (ie. only support Linux
via sysinfo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants