Replacing rest routes with symfony routes #180
Conversation
mamazu
force-pushed
the
replace-routing
branch
2 times, most recently
from
d402723 to
422298a
Compare
|
@alexander-schranz If I would fix the codestyle for the 8.3 pipeline it would break the 7.x releases and I don't want to mix in a PHP update with this. |
| } | ||
|
|
||
| /** @phpstan-ignore-next-line */ | ||
| $kernel = new Kernel($env, $debug, $suluContext); |
There was a problem hiding this comment.
unexpected change suluContext is written by the include file:
https://github.com/sulu/SuluCommunityBundle/blob/17e2867a4caae61a295d32811838de24a112c5a4/Tests/Application/bin/adminconsole
https://github.com/sulu/SuluCommunityBundle/blob/17e2867a4caae61a295d32811838de24a112c5a4/Tests/Application/bin/websiteconsole
There was a problem hiding this comment.
When I ran php bin/console.php it didn't set it properly. I think we just need a default. Copied the fix from the core. :D
There was a problem hiding this comment.
you need to run the specific console the .php isnt here to be called directly like in other bundles
There was a problem hiding this comment.
But falling back to the admin console like core sulu also does sounds reasonable I think.
There was a problem hiding this comment.
we wanted no fallbacks in the test setups we wanted to have a clear diff between admin and console thats why no bin/console script exists in the bundles test setups ;)
There was a problem hiding this comment.
It's only just a matter of time until they get merged so I've removed the changes for now. :)
mamazu
force-pushed
the
replace-routing
branch
from
422298a to
f6655d6
Compare
mamazu
force-pushed
the
replace-routing
branch
from
f6655d6 to
f39d6fa
Compare
2 participants
What's in this PR?
Replacing rest routing with Symfony routing.
Other stuff needed to fix the pipeline:
Why?
It's not part of sulu anymore and will be removed in 3.0 anyways.