[SPIKE] Create mutable models facade over cocina models #3323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
entities
branch
12 times, most recently
from
afa1dd1 to
5cfc58f
Compare
jcoyne
force-pushed
the
entities
branch
5 times, most recently
from
d0ed3e8 to
166549b
Compare
jcoyne
commented
Apr 6, 2022
jcoyne
force-pushed
the
entities
branch
3 times, most recently
from
b042c39 to
c8ce647
Compare
jcoyne
commented
Apr 6, 2022
|
|
||
| before do | ||
| @cocina = instance_double(Cocina::Models::DRO, externalIdentifier: 'druid:987', identification: identification) | ||
| @item = build(:item, source_id: 'source id') |
jcoyne
force-pushed
the
entities
branch
2 times, most recently
from
498fa10 to
5aa055b
Compare
jcoyne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
This makes working with Reform forms easier. We no longer need to have a serialize and deserialze method for each form class that we use. This also makes it possible to use FactoryBot, as it requires mutable models. These changes should make it possible for Rails developers to work with these models as if they were ActiveRecord objects and not have to be concerned about how they are serialized or deserialized to cocina.
How was this change tested? 🤨
Test suite