Skip to content

Conversation

@hudajkhan
Copy link
Contributor

@hudajkhan hudajkhan commented Sep 18, 2025

Closes #4737

What this PR does:

  • If the location code for an item is SAL3-SEE-OTHER, displays a "see volume" button in the availability panel on the right side of the screen and in the availability modal. The button opens up a volume modal.
  • Sets up code in catalog controller that does a search for the call number, sorted by title, and then displays the results in the modal. The "volumes_modal" view uses the volumes modal component to display the content.
  • If there are more than 4 items returned, the volumes modal will show a search box that allows users to type in any portion of the title and callnumber of interest and the matching values are bolded in the modal.
  • Note: Currently, the label shown above the see volumes button shows the location name for "SAL3-SEE-OTHER". @saseestone has updated the name in Folio to match what we want to display instead i.e . "Individual volumes catalogued separately" and those changes will be reflected next week probably in our systems.
    Screenshots

Availability section of the page shows the "see volume" button
Screenshot 2025-09-18 at 5 16 32 PM

Volumes modal

Screenshot 2025-09-18 at 5 16 41 PM

Volumes modal showing content being bolded based on what the user types in the search box
Screenshot 2025-09-18 at 5 16 47 PM

See volumes button within the availability modal
Screenshot 2025-09-18 at 5 17 00 PM

Comment on lines +17 to +22
if solr_doc.key?('lc_assigned_callnum_ssim')
solr_doc['lc_assigned_callnum_ssim'].join(', ')
elsif solr_doc.key?('item_display_struct')
solr_doc['item_display_struct'][0]['callnumber']
else
''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the call number logic we want to use. Maybe there's existing code for browse nearby that does it correctly? (At the very least, using the LC assigned call number by default is giving us bad call number data when our local call numbers don't match (e.g. we're using Dewey or something)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can look into browse nearby. I was quite unsure about how call numbers are supposed to work here so was hoping for some feedback on this part.

@@ -0,0 +1,33 @@
<%= render Blacklight::System::ModalComponent.new do |component| %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sarah reports that maybe this modal isn't scrollable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update display of Analytics

3 participants