Use friendly library names in page title #5831
Conversation
marlo-longley
force-pushed
the
results-library-page
branch
from
297813f to
641f124
Compare
|
Is there no hope doing this upstream/when we're initially constructing the text? |
|
https://github.com/projectblacklight/blacklight/blob/d241cbbd27d0b223b48285e9bb229886bffb6a5a/app/helpers/blacklight/catalog_helper_behavior.rb#L131 This is my read on where the text is being constructed. Since BL doesn't know about our Stanford library codes I am not sure. |
|
I looked into this a little bit and to fix it we would need to override the facetfieldpresenter. Honestly I think this really an issue in upstream blacklight. We have a helper method on the facet which is how the library is showing up with the right information right now. The title shouldn't ignore the helper on the facet. I am going to look around upstream and see if we can get it fixed there. |
|
So blacklight doesn't ignore helper methods. I think it might be a bug in one of our overrides that is causing the problem. I can't quick figure out the problem though. Might be something for the next wc |
|
Thanks for looking into this Niqui -- happy to discuss more |
Fixes #5825