Skip to content

Conversation

@dnoneill
Copy link
Contributor

There is a weird turbo load bar even after the articles+ tab has loaded. This fixes that.

@dnoneill dnoneill changed the title fix tab zeroing out on click stop turbo loading tabs Jul 23, 2025
@cbeer
Copy link
Member

cbeer commented Jul 23, 2025

I'm not sure if this is what you're seeing, but for me:

  • I load the bookmarks page
  • I click articles+ page (loading bar goes)
  • I click catalog, the page loads from the turbo cache and the loading bar displays while the actual page is reloading (and then disappears after)

I think that's normal behavior for turbo (although maybe a little weird when e.g. EDS takes a long time). Is that what you're trying to fix, or something different?

@dnoneill
Copy link
Contributor Author

dnoneill commented Jul 24, 2025

That and the turbo bar will still be there after the page loads. It is just kind of a weird behavior and it would probably be better not to turbo those tabs. The screenshot below is after I have hit the articles tab. Maybe it's fine it just seemed really weird to me. Also at least locally for me the articles tab with zero out when loading sometimes. It just seems kind of off.
Screenshot 2025-07-24 at 10 48 19 AM

@jcoyne
Copy link
Contributor

jcoyne commented Jul 28, 2025

@cbeer I think your analysis is correct. It's showing the cached page while the spinner is running, and after 4s or so, it finishes the request. This is the default Turbo behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants