Skip to content

Conversation

@dnoneill
Copy link
Contributor

@dnoneill dnoneill commented May 20, 2025

closes #1832
needs ebsco/edsapi-ruby#131 to work

Screenshot 2025-05-22 at 12 22 49 PM
Screenshot 2025-05-22 at 12 22 36 PM

@dnoneill dnoneill force-pushed the 1832-eds-pub-date branch 4 times, most recently from cd9977f to 58b6bb2 Compare May 22, 2025 16:37
@dnoneill dnoneill force-pushed the 1832-eds-pub-date branch from 58b6bb2 to 93823b7 Compare May 22, 2025 16:42
@dbranchini
Copy link

Screenshots look good. Thank you!

@cbeer
Copy link
Member

cbeer commented May 22, 2025

@dbranchini : are radio buttons the right affordance for this, or would it be better to treat them as regular facet links? With the radio buttons, it seems a little harder to escape from that context and get back to using the date slider (and.. are optional radio buttons even ok?)

@dbranchini
Copy link

I'm not sure what you mean by "optional radio buttons"? (I assume they work as a group and you can only select one.) I noticed the radio buttons when Niqui implemented it. I think they're appropriate, but probably better if all of our facets were either radio buttons or checkboxes or none at all. Since I didn't give her much guidance to begin with, initially I thought I'd let it go. BUT this is probably the right time to fix it. Let's go with a standard facet link since that's what we use everywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Facet based on recent publication date

4 participants