core:backend: enable overriding BASE_DIR setting #906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Django backend currently collects static files and creates a
/data
directory to store them.DATA_DIR
path is hardcoded as/
and that can cause some systems to throw errors (Mac, PaaS, VMs and containers, and other systems with strict read-only permissions ). The error will look like this:Changes in this PR allow developers to override the path in order to test the backend in any environment.
Proposal
I propose to avoid hardcoding the backend root as an absolute system path and replace it by the variable
BASE_DIR
, which is a standard Django convention.DATA_DIR
will always point to Django project's root directory by default to create/data
, unless specified otherwise.Note: similar to #893 but with a different method.