➕(backend) add django-lasuite dependency
#839
Open
+126
−609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbey
force-pushed
the
qbey/use-django-lasuite
branch
7 times, most recently
from
671336c to
9af8edd
Compare
There was a problem hiding this comment.
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/backend/core/tests/authentication/test_views.py:1
- The removal of authentication view tests may lead to reduced test coverage for the logout and callback flows. Please double-check that the new OIDC functionality from django-lasuite is comprehensively tested elsewhere.
Removed entire file
9af8edd to
067b41f
Compare
qbey
force-pushed
the
qbey/use-django-lasuite
branch
from
067b41f to
b724000
Compare
lunika
reviewed
Apr 14, 2025
Comment on lines
-36
to
+37
| USER_OIDC_FIELD_TO_SHORTNAME: "given_name" | ||
| USER_OIDC_FIELDS_TO_FULLNAME: "given_name,usual_name" | ||
| OIDC_USERINFO_SHORTNAME_FIELD: "given_name" | ||
| OIDC_USERINFO_FULLNAME_FIELDS: "given_name,usual_name" |
There was a problem hiding this comment.
I don't know how to deal with it. Renaming it directly is a breaking change. Having both makes non sense has the new settings will overwrite the legacy one.
Use the OIDC backend from the new library and add settings to setup OIDC token storage required for later calls to OIDC Resource Servers.
qbey
force-pushed
the
qbey/use-django-lasuite
branch
from
b724000 to
07911a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We work on a common library for our project (https://github.com/suitenumerique/django-lasuite), this is the first step on this.
Proposal
Use the OIDC backends from the new library.
OIDCAuthenticationBackenddjango-lasuitein thepyproject.tomlfile