chore: update OSV-Scanner to v2.0.2 #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a Makefile to allow vulnerability scans of dependencies to be run locally more easily. - `make scan` to scan all components. - `make component=core scan` to scan only the core component. - `make clean` to remove Gradle lockfiles used for scans. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
osv-scanner
branch
from
c87f282 to
e762ee4
Compare
vbarua
approved these changes
May 7, 2025
|
|
||
| .PHONY: clean | ||
| clean: | ||
| find . -depth 2 -type f -name gradle.lockfile -delete -print |
There was a problem hiding this comment.
I really like using Makefiles for stuff like this 🔧
This makes me want to add (in the future) targets like make build, make test and make format to invoke Gradle as it makes it easier for new contributors to run the codebase for the first time. When we do that, I would also want to have make clean invoke ./gradlew clean. Would that cause any issues for your work here?
There was a problem hiding this comment.
Not at all. It sounds like a great idea to me. If you wanted to keep the Makefile targets more granular as it is extended, the clean target in this change could be renamed to scan-clean (or clean-scan), and the (new) clean target could depend on scan-clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a Makefile to allow vulnerability scans of dependencies to be run locally more easily.
make scanto scan all components.make component=core scanto scan only the core component.make cleanto remove Gradle lockfiles used for scans.