Skip to content

test(isthmus): round-trip testing of TPC queries #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

bestbeforetoday
Copy link
Contributor

In addition to the existing testing of conversion from TPC-H and TPC-DS SQL queries to Substrait, test conversion of the generated Substrait back to SQL.

@bestbeforetoday
Copy link
Contributor Author

Inspired by some of the additional testing in #383.

@bestbeforetoday bestbeforetoday marked this pull request as ready for review May 2, 2025 17:09
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall. Just had one question around printing the plans and SQL strings.

return Arrays.stream(values)
.filter(t -> !t.trim().isBlank())
.collect(java.util.stream.Collectors.toList());
/** Holder class to load TPC-H create statements only once on first access. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea ✨

In addition to the existing testing of conversion from TPC-H and TPC-DS
SQL queries to Substrait, test conversion of the generated Substrait
back to SQL.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Co-authored-by: MBWhite <whitemat@uk.ibm.com>
@vbarua vbarua changed the title chore(isthmus): round-trip testing of TPC queries test(isthmus): round-trip testing of TPC queries May 7, 2025
@vbarua vbarua merged commit 25a2f09 into substrait-io:main May 7, 2025
12 checks passed
@bestbeforetoday bestbeforetoday deleted the tpc-roundtrip-tests branch May 7, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants