Skip to content

chore(isthmus): enable working TPC-DS query test #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

bestbeforetoday
Copy link
Contributor

Other changes have allowed TPC-DS query 2 to be converted to Substrait without error. This query previously failed due to lack of support for rouding decimals.

This change enables the unit test for TPC-DS query 2.

Other changes have allowed TPC-DS query 2 to be converted to Substrait
without error. This query previously failed due to lack of support for
rouding decimals.

This change enables the unit test for TPC-DS query 2.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
@bestbeforetoday bestbeforetoday marked this pull request as ready for review April 24, 2025 14:00
Copy link
Contributor

@Blizzara Blizzara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Blizzara Blizzara merged commit da003bf into substrait-io:main Apr 24, 2025
12 checks passed
@bestbeforetoday bestbeforetoday deleted the tpc-ds branch April 24, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants