feat(spark): make SparkSession optional #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ToLogicalPlan class constructor takes a SparkSession argument which must be supplied by the caller. We can simplify the API by making this parameter optional, and defaulting to `SparkSession.builder().getOrCreate()`. The `LocalFiles.scala` test has been modified so that both usages get tested. The need for this was triggered by invoking this API from Python code (pyspark). Passing the SparkSession object from python involves accessing internal handles, which doesn’t make for a good user experience.
Blizzara
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ToLogicalPlanclass constructor takes a SparkSession argument which must be supplied by the caller.We can simplify the API by making this parameter optional, and defaulting to
SparkSession.builder().getOrCreate(). TheLocalFiles.scalatest has been modified so that both usages get tested.The need for this was triggered by invoking this API from Python code (pyspark). Passing the SparkSession object from python involves accessing internal handles, which doesn’t make for a good user experience.