Skip to content

feat(isthmus): always emit Cross relation when possible #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

vbarua
Copy link
Member

@vbarua vbarua commented Apr 3, 2025

BREAKING CHANGE: removed CrossJoinPolicy from FeatureBoard

BREAKING CHANGE: removed CrossJoinPolicy from FeatureBoard
@vbarua
Copy link
Member Author

vbarua commented Apr 3, 2025

The default policy is already to emit Cross relations

/**
* @return the selected cross join policy
*/
@Value.Default
public CrossJoinPolicy crossJoinPolicy() {
return CrossJoinPolicy.KEEP_AS_CROSS_JOIN;
}

If a downstream consumer can handle the Join relation, but not the Cross relation, it should be updated the Cross relation rather than having an optional processing override in our system.

@vbarua vbarua merged commit 7705243 into main Apr 3, 2025
13 checks passed
@vbarua vbarua deleted the vbarua/always-emit-cross-joins branch April 3, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants