Skip to content

build: make spotless run more reliably #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

nielspardon
Copy link
Contributor

When I run ./gradlew clean build on my local clone I constantly see Spotless tripping up on files in the build folder no longer existing which means I have to run the command multiple times. This suggests to me that the targetExclude configuration does not work as expected.

Instead this PRs configures the target to format every *.java file within any of the src/*/java/** directories which works more reliably and achieves the same goal as the current configuration.

This PR also adds .metals to the .gitignore for the VS Code users among us which uses metals for the Scala code.

Signed-off-by: Niels Pardon <par@zurich.ibm.com>
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ./gradlew spotlessJavaApply and spotless is still applied as expected. Changes look reasonable to me.

@vbarua vbarua merged commit 30cb975 into substrait-io:main Mar 27, 2025
13 checks passed
@nielspardon nielspardon deleted the par-spotless branch April 7, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants