add support for nested types #160
Conversation
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
|
|
| PRAGMA enable_verification | ||
|
|
||
| statement ok | ||
| CREATE TABLE nested_test ( |
There was a problem hiding this comment.
I'd like to see additional nesting (a struct, list, or map within one of the others).
| @@ -0,0 +1,46 @@ | |||
| # name: test/sql/test_substrait_nested_types.test | |||
| # description: Test nested type support in substrait extension (LIST, MAP, ARRAY) | |||
There was a problem hiding this comment.
What's the difference between a list and an array? Is STRUCT supposed to be listed here?
There was a problem hiding this comment.
Ah sorry, leftover... I tried to implement the ARRAY type (fixed-length list basically), and reverted it because I didn't have a clear use case for it, and it was harder to test due to Substrait not having fixed-length arrays.
I'll remove ARRAY from the comment here.
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
|
I went ahead and addressed the requested changes and added more tests, let me know if anything else needs to be changed! |
|
Thanks for the quick turn around and feedback! |
This PR adds missing support for nested types.
I ran
make format, hence some of the formatting changes.