changes to use 1.2.1 version of duckdb and extension-ci-tools. #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymurr
approved these changes
Mar 11, 2025
EpsilonPrime
approved these changes
Mar 11, 2025
| @@ -21,8 +21,8 @@ jobs: | |||
| name: Build extension binaries | |||
| uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main | |||
| with: | |||
| duckdb_version: c009b4ea62f9fcf6ffed6aad51c8f1833121bbfb | |||
| ci_tools_version: 8262e6fafa6b62a82f9d671d33d311b9b578127e | |||
| duckdb_version: 8e52ec43959ab363643d63cb78ee214577111da4 | |||
There was a problem hiding this comment.
It feels like this ought to be the main version of duckdb based on the name of the workflow but the other one had the main label?
There was a problem hiding this comment.
why do we even have two nearly identical worfklows? Seems like main will occasionally break and (maybe) stop us from merging?
There was a problem hiding this comment.
Initially both were pointing to main, then we changed it to specific commit-id in this commit.
distribution.yml workflow is not triggered as part of this PR.
EpsilonPrime
added a commit
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.