Skip to content

feat: Return not implemented errors instead of internal errors #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

EpsilonPrime
Copy link
Member

@EpsilonPrime EpsilonPrime commented Mar 7, 2025

For unsupported features we now return not implemented errors instead of internal errors. This means that subsequent queries will be able to proceed instead of requiring DuckDB to be restarted.

@EpsilonPrime EpsilonPrime requested a review from scgkiran March 7, 2025 08:11
scgkiran
scgkiran previously approved these changes Mar 7, 2025
scgkiran
scgkiran previously approved these changes Mar 7, 2025
@EpsilonPrime EpsilonPrime merged commit 611d92b into substrait-io:main Mar 7, 2025
27 checks passed
@EpsilonPrime EpsilonPrime deleted the type_errors branch March 7, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants