This repository was archived by the owner on Sep 21, 2024. It is now read-only.
feat: Do not proactively create directories when creating spheres via CLI. Fixes #599 #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a rationale for the change? Maybe a test? |
cdata
reviewed
Sep 19, 2023
In #599, for early failures (like an invalid key), the SpherePaths initialization proactively creates all of the |
|
Thanks, I missed that the bug was in the title at first 👍 |
cdata
reviewed
Sep 19, 2023
jsantell
force-pushed
the
599
branch
3 times, most recently
from
f2c389e to
90f36d2
Compare
Test flake analysisNo flakes detected 🎉
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.