Skip to content

refactor!: remove DataLoaderPreparedRequestExecutor #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stuebingerb
Copy link
Owner

Adds proper handling for dataProperties to ParallelRequestExecutor and gets rid of DataLoaderPreparedRequestExecutor, along with the option to configure the request executor in SchemaConfiguration.

This also consolidates some tests that were hardcoded to use one of the request executors, and therefore missed the other.

Resolves #58
Resolves #268

BREAKING CHANGE: The option to configure request executors has been removed, and execution will now always use the ParallelRequestExecutor.

Adds proper handling for `dataProperties` to `ParallelRequestExecutor`
and gets rid of `DataLoaderPreparedRequestExecutor`, along with the
option to configure the request executor in `SchemaConfiguration`.

This also consolidates some tests that were hardcoded to use one of
the request executors, and therefore missed the other.

Resolves #58
Resolves #268

BREAKING CHANGE: The option to configure request executors has been
removed, and execution will now always use the `ParallelRequestExecutor`.
@stuebingerb stuebingerb force-pushed the refactor/remove-dataloaderprepared-executor branch from 42d0244 to 9d37255 Compare June 22, 2025 13:26
@stuebingerb
Copy link
Owner Author

stuebingerb commented Jun 22, 2025

This feels way too easy but there seems to be only one test that actually validates DataLoader specifics (DataLoaderTest#data loader cache per request only).

Already open for review but I want to have a bit more test coverage.

Edit: basic data loader validates as well but I still feel like I'm missing something.

Copy link

codecov bot commented Jun 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.26%. Comparing base (3a71dba) to head (9d37255).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   73.23%   74.26%   +1.02%     
==========================================
  Files         161      159       -2     
  Lines        5142     4923     -219     
  Branches      910      847      -63     
==========================================
- Hits         3766     3656     -110     
+ Misses       1035      955      -80     
+ Partials      341      312      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stuebingerb
Copy link
Owner Author

Removing the one request executor that already works with kotlinx.serialization seems bad for #224 but my gut feeling is that this would still be a step in the right direction. Both executors have diverged and I believe it is easier to migrate the existing one than solving existing issues with DataLoaderPreparedRequestExecutor and adding missing functionality there. Feel free to disagree, though, happy to have a discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate request executors Take over or replace DeferredJsonBuilder
1 participant