Set up headless task when using StripeProvider #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
requested review from
a team and
charliecruzan-stripe
as code owners
janicduplessis
commented
Sep 16, 2025
| await NativeStripeSdk.initialise({ | ||
| await initStripe({ | ||
| publishableKey, | ||
| appInfo, |
There was a problem hiding this comment.
App info is added by initStripe already.
janicduplessis
force-pushed
the
@janic/fix-init
branch
from
1f2d683 to
706c442
Compare
porter-stripe
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When initializing the app via
StripeProviderwe never end up registering the headless task. To fix it I changed the Provider to callinitStripeso we now have only one initialization code path. I also added a check to make sure the task only gets registered once, as I assume it could happen that multipleStripeProviderare rendered.Motivation
Task should be registered when using
StripeProviderTesting
Documentation
Select one: