Gbirch/9 25 card scan close signalling #5677
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // If we are leaving the screen, we should stop (but not close) the scanner | ||
| if newWindow == nil { | ||
| cardScanningView.stopScanner() |
There was a problem hiding this comment.
Are there other situations where we'd want to stop the scanner but another field isn't editing?
|
🚨 New dead code detected in this PR: IndividualViewController.swift:102 warning: Parameter 'element' is unused
PayWithLinkViewController-UpdatePaymentViewController.swift:232 warning: Parameter 'element' is unused
PayWithLinkViewController-WalletViewController.swift:610 warning: Parameter 'element' is unused
LinkInlineSignupView.swift:342 warning: Parameter 'element' is unused
LinkEmailElement.swift:118 warning: Parameter 'element' is unused
LinkPaymentMethodFormElement.swift:308 warning: Parameter 'element' is unused
LinkSignUpViewController.swift:346 warning: Parameter 'element' is unused
AddressViewController.swift:516 warning: Parameter 'element' is unused
CustomerAddPaymentMethodViewController.swift:417 warning: Parameter 'element' is unused
CardSectionWithScannerView.swift:37 warning: Property 'opensCardScannerAutomatically' is assigned, but never used
PaymentMethodElementWrapper.swift:120 warning: Parameter 'element' is unused
SavedPaymentOptionsViewController.swift:847 warning: Parameter 'element' is unused
AutoCompleteViewController.swift:249 warning: Parameter 'element' is unused
CVCReconfirmationViewController.swift:161 warning: Parameter 'element' is unused
PaymentMethodFormViewController.swift:264 warning: Parameter 'element' is unused
PaymentSheetVerticalViewController.swift:1158 warning: Parameter 'element' is unused
UpdatePaymentMethodViewController.swift:409 warning: Parameter 'element' is unused
ContainerElement.swift:73 warning: Parameter 'element' is unused
Element.swift:75 warning: Parameter 'element' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog