Skip to content

Remove material-icons libraries #11833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Remove material-icons libraries #11833

wants to merge 2 commits into from
+314 −739

Conversation

@samer-stripe
Copy link
Collaborator

Summary

Remove material-icons libraries

Motivation

Prepping for Jetpack Compose 1.9.4 and in general we shouldn't be using these libraries anymore per release notes for Material 3:

The androidx.compose.material.icons library is no longer recommended for displaying Material Icons in Compose, as Material Symbols are the new way forward. We have stopped publishing updates to this library and it has been removed from the latest Material 3 library release, you can still manually reference it if you cannot migrate yet.

Instead, we recommend downloading a Vector Drawable XML file from the Android tab of https://fonts.google.com/icons to get access to the latest styled icons: Material Symbols.

Why are we not recommending the library anymore? The icons library ("Material Icons") have been superseded by the newer look of Material Symbols and we've seen that the library can increase the build time of your apps significantly as it includes all the various icons that may not be needed.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@github-actions
Copy link
Contributor

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

samer-stripe
samer-stripe commented Oct 28, 2025
View reviewed changes
connect-example/src/main/java/com/stripe/android/connect/example/ui/common/Buttons.kt
fun BackIconButton(onClick: () -> Unit) {
IconButton(onClick = onClick) {
Icon(
imageVector = Icons.AutoMirrored.Filled.ArrowBack,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoMirrored added now on all icon XML definitions

samer-stripe
samer-stripe commented Oct 28, 2025
View reviewed changes
connect-example/src/main/res/drawable/ic_material_close.xml
<path
android:fillColor="@android:color/white"
android:pathData="M256,760L200,704L424,480L200,256L256,200L480,424L704,200L760,256L536,480L760,704L704,760L480,536L256,760Z"/>
</vector>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied the icons in all the example apps. Better represents how we would build an app using our APIs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed             │           uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff      
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
      dex │   4.8 MiB │   4.8 MiB │  -5.7 KiB │  10.7 MiB │  10.7 MiB │  -1.3 KiB 
     arsc │   2.6 MiB │   2.6 MiB │ -10.6 KiB │   2.6 MiB │   2.6 MiB │ -10.6 KiB 
 manifest │   5.8 KiB │   5.8 KiB │       0 B │  30.6 KiB │  30.6 KiB │       0 B 
      res │ 928.7 KiB │   935 KiB │  +6.3 KiB │   1.5 MiB │   1.5 MiB │ +10.4 KiB 
   native │   3.5 MiB │   3.5 MiB │       0 B │   8.5 MiB │   8.5 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │    +345 B │   1.6 MiB │   1.6 MiB │     -31 B 
    other │ 198.6 KiB │ 198.6 KiB │     +49 B │ 373.8 KiB │ 374.9 KiB │  +1.1 KiB 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
    total │  13.7 MiB │  13.7 MiB │  -9.6 KiB │  25.3 MiB │  25.3 MiB │    -477 B 

         │         raw          │               unique                
         ├───────┬───────┬──────┼───────┬───────┬─────────────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff                
─────────┼───────┼───────┼──────┼───────┼───────┼─────────────────────
   files │     2 │     2 │    0 │       │       │                     
 strings │ 54865 │ 54822 │  -43 │ 50319 │ 50305 │ -14 (+6974 -6988)   
   types │ 19744 │ 19747 │   +3 │ 17541 │ 17540 │  -1 (+6971 -6972)   
 classes │ 14815 │ 14814 │   -1 │ 14815 │ 14814 │  -1 (+5846 -5847)   
 methods │ 75783 │ 75823 │  +40 │ 72364 │ 72360 │  -4 (+44365 -44369) 
  fields │ 49646 │ 49622 │  -24 │ 48281 │ 48266 │ -15 (+33088 -33103) 

 ARSC    │ old  │ new  │ diff        
─────────┼──────┼──────┼─────────────
 configs │  242 │  242 │  0          
 entries │ 6364 │ 6373 │ +9 (+12 -3)
APK 
      compressed       │     uncompressed      │                                                                      
───────────┬───────────┼───────────┬───────────┤                                                                      
 size      │ diff      │ size      │ diff      │ path                                                                 
───────────┼───────────┼───────────┼───────────┼──────────────────────────────────────────────────────────────────────
   2.6 MiB │ -10.6 KiB │   2.6 MiB │ -10.6 KiB │ ∆ resources.arsc                                                     
   4.3 MiB │ -10.4 KiB │   9.5 MiB │ -11.6 KiB │ ∆ classes.dex                                                        
 544.6 KiB │  +4.7 KiB │   1.2 MiB │ +10.3 KiB │ ∆ classes2.dex                                                       
     662 B │    +662 B │   1.3 KiB │  +1.3 KiB │ + res/qp.xml                                                         
     662 B │    +662 B │   1.3 KiB │  +1.3 KiB │ + res/s9.xml                                                         
     657 B │    +657 B │   1.1 KiB │  +1.1 KiB │ + res/Sb.xml                                                         
     591 B │    +591 B │     944 B │    +944 B │ + res/W8.xml                                                         
     585 B │    +585 B │     972 B │    +972 B │ + res/Av.xml                                                         
     575 B │    +575 B │   1,008 B │  +1,008 B │ + res/Kp.xml                                                         
     493 B │    +493 B │     748 B │    +748 B │ + res/Bl.xml                                                         
     458 B │    +458 B │     672 B │    +672 B │ + res/NK.xml                                                         
     446 B │    +446 B │     648 B │    +648 B │ + res/Sv.xml                                                         
     438 B │    +438 B │     652 B │    +652 B │ + res/3T.xml                                                         
     438 B │    +438 B │     652 B │    +652 B │ + res/Me.xml                                                         
     426 B │    +426 B │     604 B │    +604 B │ + res/PU.xml                                                         
   9.5 KiB │    +381 B │   9.3 KiB │    +381 B │ ∆ assets/dexopt/baseline.prof                                        
    52 KiB │    +355 B │ 122.9 KiB │    +584 B │ ∆ META-INF/MANIFEST.MF                                               
  55.5 KiB │    +310 B │   123 KiB │    +584 B │ ∆ META-INF/CERT.SF                                                   
           │    -216 B │           │      -6 B │ - META-INF/androidx.compose.material_material-icons-extended.version 
           │    -208 B │           │      -6 B │ - META-INF/androidx.compose.material_material-icons-core.version     
           │    -190 B │           │      -6 B │ - META-INF/androidx.compose.material3_material3.version              
     127 B │    +127 B │       5 B │      +5 B │ + META-INF/services/ab.x                                             
     127 B │    +127 B │       5 B │      +5 B │ + META-INF/services/bb.a                                             
           │    -127 B │           │      -5 B │ - META-INF/services/eb.x                                             
           │    -127 B │           │      -5 B │ - META-INF/services/fb.a                                             
   1.9 KiB │     -45 B │   7.5 KiB │    -421 B │ ∆ assets/sentry-external-modules.txt                                 
   1.2 KiB │      +9 B │     1 KiB │      +9 B │ ∆ assets/dexopt/baseline.profm                                       
     533 B │      -9 B │     984 B │       0 B │ ∆ res/J7.xml                                                         
     651 B │      -4 B │     2 KiB │       0 B │ ∆ res/cA.xml                                                         
     803 B │      +3 B │   1.7 KiB │       0 B │ ∆ res/0H.xml                                                         
   1.2 KiB │      +2 B │   3.7 KiB │       0 B │ ∆ res/BH.xml                                                         
     907 B │      +2 B │   2.4 KiB │       0 B │ ∆ res/YB.xml                                                         
     951 B │      +2 B │   2.5 KiB │       0 B │ ∆ res/de.xml                                                         
     461 B │      +2 B │     824 B │       0 B │ ∆ res/e-.xml                                    
...✂
DEX 
STRINGS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   50319 │ 50305 │ -14 (+6974 -6988) 
  
  + LA2/A;
  + LA2/B;
  + LA2/C;
  + LA2/D;
  + LA2/E;
  + LA2/F;
  + LA2/G;
  + LA2/H;
  + LA2/I;
  + LA2/J;
  + LA2/K;
  + LA2/L;
  + LA2/M;
  + LA2/N;
  + LA2/O;
  + LA2/P;
  + LA2/c;
  + LA2/d;
  + LA2/e;
  + LA2/f;
  + LA2/g;
  + LA2/h;
  + LA2/i;
  + LA2/j;
  + LA2/k;
  + LA2/l;
  + LA2/m;
  + LA2/n;
  + LA2/o;
  + LA2/p;
  + LA2/q;
  + LA2/r;
  + LA2/s;
  + LA2/t;
  + LA2/u;
  + LA2/v;
  + LA2/w;
  + LA2/x;
  + LA2/y;
  + LA2/z;
  + LA4/b;
  + LA4/c;
  + LA4/d;
  + LA4/e;
  + LA6/L;
  + LA6/M;
  + LA6/N;
  + LA6/O;
  + LA6/P;
  + LA6/Q;
  + LA6/S;
  + LA6/T;
  + LA6/U;
  + LA6/V;
  + LA6/W;
  + LA6/X;
  + LA6/Y;
  + LA6/Z;
  + LA6/a0;
  + LA6/b0;
  + LA6/c0;
  + LA6/d0;
  + LA6/e0;
  + LA6/f0;
  + LA6/g0;
  + LA6/h0;
  + LA6/i0;
  + LA6/j0;
  + LA6/k0;
  + LA6/l0;
  + LA6/m0;
  + LA6/n0;
  + LA6/o0;
  + LA7/A;
  + LA7/B;
  + LA7/C;
  + LA7/D;
  + LA7/E;
  + LA7/F;
  + LA7/r;
  + LA7/s;
  + LA7/t;
  + LA7/u;
  + LA7/v;
  + LA7/w;
  + LA7/x;
  + LA7/y;
  + LA7/z;
  + LB1/f;
  + LB1/g;
  + LB1/h;
  + LB1/i;
  + LB1/j;
  + LB1/k;
  + LB1/l;
  + LB1/m;
  + LB1/n;
  + LB1/o;
  + LB1/p;
  + LB1/q;
  + LB3/b;
  + LB3/c;
  + LB3/d;
  + LB3/e;
  + LB3/f;
  + LB3/g;
  + LB3/h;
  + LB3/i;
  + LB3/j;
  + LB3/k;
  + LB7/A0;
  + LB7/A;
  + LB7/B0;
  + LB7/B;
  + LB7/C;
  + LB7/D;
  + LB7/E;
  + LB7/F;
  + LB7/G;
  + LB7/H;
  + LB7/I;
  + LB7/J;
  + LB7/K;
  + LB7/L;
  + LB7/M;
  + LB7/N;
  + LB7/O;
  + LB7/P;
  + LB7/Q;
  + LB7/S;
  + LB7/T;
  + LB7/U;
  + LB7/V;
  + LB7/W;
  + LB7/X;
  + LB7/Y;
  + LB7/Z;
  + LB7/a0;
  + LB7/b0;
  + LB7/c0;
  + LB7/d0;
  + LB7/e0;
  + LB7/f0;
  + LB7/f;
  + LB7/g0;
  + LB7/g;
  + LB7/h0;
  + LB7/h;
  + LB7/i0;
  + LB7/i;
  + LB7/j0;
  + LB7/j;
  + LB7/k0;
  + LB7/k;
  + LB7/l0;
  + LB7/l;
  + LB7/m0;
  + LB7/m;
  + LB7/n0;
  + LB7/n;
  + LB7/o0;
  + LB7/o;
  + LB7/p0;
  + LB7/p;
  + LB7/q0;
  + LB7/q;
  + LB7/r0;
  + LB7/r;
  + LB7/s0;
  + LB7/s;
  + LB7/t0;
  + LB7/t;
  + LB7/u0;
  + LB7/u;
  + LB7/v0;
  + LB7/v;
  + LB7/w0;
  + LB7/w;
  + LB7/x0;
  + LB7/x;
  + LB7/y0;
  + LB7/y;
  + LB7/z0;
  + LB7/z;
  + LB8/g;
  + LB8/h;
  + LB8/i;
  + LB8/j;
  + LB8/k;
  + LB8/l;
  + LB9/A;
  + LB9/B;
  + LB9/C;
  + LB9/D;
  + LB9/E;
  + LB9/F;
  + LB9/G;
  + LB9/H;
  + LB9/I;
  + LB9/J;
  + LB9/K;
  + LB9/L;
  + LB9/M;
  + LB9/N;
  + LB9/O;
  + LB9/P;
  + LB9/Q;
  + LB9/S;
  + LB9/T;
  + LB9/U;
  + LB9/V;
  + LB9/W;
  + LB9/X;
  + LB9/Y;
  + LB9/Z;
  + LB9/a0;
  + LB9/b0;
  + LB9/c0;
  + LB9/d0;
  + LB9/k;
  + LB9/l;
  + LB9/m;
  + LB9/n;
  + LB9/o;
  + LB9/p;
  + LB9/q;
  + LB9/r;
  + LB9/s;
  + LB9/t;
  + LB9/u;
  + LB9/v;
  + LB9/w;
  + LB9/x;
  + LB9/y;
  + LB9/z;
  + LC2/e;
  + LC2/f;
  + LC2/g;
  + LC2/h;
  + LC2/i;
  + LC2/j;
  + LC2/k;
  + LC2/l;
  + LC2/m;
  + LC4/h;
  + LC4/i;
  + LC4/j;
  + LC4/k;
  + LC4/l;
  + LC4/m;
  + LC4/n;
  + LC4/o;
  + LC4/p;
  + LC4/q;
  + LC4/r;
  + LC4/s;
  + LC4/t;
  + LC4/u;
  + LC4/v;
  + LC5/i;
  + LC5/j;
  + LC6/f;
  + LC6/g;
  + LC6/h;
  + LC6/i;
  + LC6/j;
  + LC6/k;
  + LC6/l;
  + LC6/m;
  + LC6/n;
  + LC6/o;
  + LC6/p;
  + LC6/q;
  + LC6/r;
  + LC6/s;
  + LC6/t;
  + LC9/h;
  + LC9/i;
  + LC9/j;
  + LC9/k;
  + LC9/l;
  + LD1/d;
  + LD1/e;
  + LD1/f;
  + LD1/g;
  + LD1/h;
  + LD1/i;
  + LD1/j;
  + LD1/k;
  + LD1/l;
  + LD1/m;
  + LD1/n;
  + LD1/o;
  + LD3/c;
  + LD3/d;
  + LD3/e;
  + LD3/f;
  + LD4/b;
  + LD5/a;
  + LD5/b;
  + LD7/e;
  + LD7/f;
  + LD7/g;
  + LD7/h;
  + LD7/i;
  + LD7/j;
  + LD8/A0;
  + LD8/A;
  + LD8/B0;
  + LD8/B;
  + LD8/C0;
  + LD8/C;
  + LD8/D0;
  + LD8/D;
  + LD8/E0;
  + LD8/E;
  + LD8/F0;
  + LD8/F;
  + LD8/G0;
  + LD8/G;
  + LD8/H0;
  + LD8/H;
  + LD8/I0;
  + LD8/I;
  + LD8/J0;
  + LD8/J;
  + LD8/K0;
  + LD8/K;
  + LD8/L0;
  + LD8/L;
  + LD8/M0;
  + LD8/M;
  + LD8/N0;
  + LD8/N;
  + LD8/O0;
  + LD8/O;
  + LD8/P0;
  + LD8/P;
  + LD8/Q0;
  + LD8/Q;
  + LD8/R0;
  + LD8/S0;
  + LD8/S;
  + LD8/T0;
  + LD8/T;
  + LD8/U0;
  + LD8/U;
  + LD8/V0;
  + LD8/V;
  + LD8/W0;
  + LD8/W;
  + LD8/X0;
  + LD8/X;
  + LD8/Y0;
  + LD8/Y;
  + LD8/Z0;
  + LD8/Z;
  + LD8/a0;
  + LD8/a1;
  + LD8/b0;
  + LD8/b1;
  + LD8/b;
  + LD8/c0;
  + LD8/c1;
  + LD8/c;
  + LD8/d0;
  + LD8/d1;
  + LD8/d;
  + LD8/e0;
  + LD8/e1;
  + LD8/e;
  + LD8/f0;
  + LD8/f1;
  + LD8/f;
  + LD8/g0;
  + LD8/g1;
  + LD8/g;
  + LD8/h0;
  + LD8/h1;
  + LD8/h;
  + LD8/i0;
  + LD8/i1;
  + LD8/i;
  + LD8/j0;
  + LD8/j1;
  + LD8/j;
  + LD8/k0;
  + LD8/k1;
  + LD8/k;
...✂
ARSC 
ENTRIES:

   old  │ new  │ diff        
  ──────┼──────┼─────────────
   6364 │ 6373 │ +9 (+12 -3) 
  + drawable/ic_add
  + drawable/ic_close
  + drawable/ic_info
  + drawable/ic_remove
  + drawable/ic_search
  + drawable/stripe_ic_material_arrow_back
  + drawable/stripe_ic_material_cancel
  + drawable/stripe_ic_material_check
  + drawable/stripe_ic_material_close
  + drawable/stripe_ic_material_info
  + drawable/stripe_ic_material_keyboard_arrow_right
  + drawable/stripe_ic_material_more_vert
  
  - string/collapsed
  - string/dialog
  - string/expanded

@samer-stripe samer-stripe force-pushed the samer/remove-material-icons-library branch from 95aa989 to 1d61fa4 Compare October 29, 2025 05:56
@samer-stripe samer-stripe added the accept-risky-change accept-risky-change label Oct 29, 2025
@samer-stripe samer-stripe force-pushed the samer/remove-material-icons-library branch from 1d61fa4 to 9460870 Compare October 29, 2025 06:03
@samer-stripe samer-stripe force-pushed the samer/remove-material-icons-library branch from 9460870 to 17735e6 Compare October 29, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

accept-risky-change accept-risky-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samer-stripe