-
Couldn't load subscription status.
- Fork 694
Stripe CryptoOnramp: KYC Refresh Endpoints #11831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Diffuse output: APK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, just a couple small things
| @SerialName("zip") | ||
| val postalCode: String?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be postal_code, or is the spec in the doc incorrect?
| @SerialName("zip") | |
| val postalCode: String?, | |
| @SerialName("postal_code") | |
| val postalCode: String?, |
Either way, the serialized string should match the symbol name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the conversation that was had here, and I also believe in the linked PRD spec, the serialized name for the request is indeed "zip", while the response for the refresh is "postal_code", and that is intentional.
I can rename the symbol, but this pattern does match the existing KYCCollectionRequest, and this from searching would be the first time we would use zip as a symbol name. Let me know if you prefer that.
Summary
CryptoApiRepository.Motivation
Implementing as part of the KYC refresh spec.
Testing