Skip to content

Conversation

@Twigz
Copy link
Collaborator

@Twigz Twigz commented Oct 28, 2025

Summary

  • Adds new models for KYC refresh APIs
  • Adds new network api requests for KYC refreshing to the CryptoApiRepository.
  • Adds tests to verify behavior

Motivation

Implementing as part of the KYC refresh spec.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@Twigz Twigz requested a review from lng-stripe October 28, 2025 17:11
@Twigz Twigz requested review from a team as code owners October 28, 2025 17:11
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │   1.1 MiB │   1.1 MiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.7 KiB │ 302.7 KiB │  0 B │ 456.5 KiB │ 456.5 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │ +8 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.5 MiB │  11.5 MiB │ +8 B │  25.4 MiB │  25.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20710 │ 20710 │ 0 (+0 -0) 
   types │  6515 │  6515 │ 0 (+0 -0) 
 classes │  5279 │  5279 │ 0 (+0 -0) 
 methods │ 31555 │ 31555 │ 0 (+0 -0) 
  fields │ 18279 │ 18279 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  163 │  163 │  0   
 entries │ 3665 │ 3665 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 29.2 KiB │ +9 B │ 64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    270 B │ -2 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 30.6 KiB │ +8 B │   66 KiB │  0 B │ (total)

Copy link
Contributor

@lng-stripe lng-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just a couple small things

Comment on lines +32 to +33
@SerialName("zip")
val postalCode: String?,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be postal_code, or is the spec in the doc incorrect?

Suggested change
@SerialName("zip")
val postalCode: String?,
@SerialName("postal_code")
val postalCode: String?,

Either way, the serialized string should match the symbol name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the conversation that was had here, and I also believe in the linked PRD spec, the serialized name for the request is indeed "zip", while the response for the refresh is "postal_code", and that is intentional.

I can rename the symbol, but this pattern does match the existing KYCCollectionRequest, and this from searching would be the first time we would use zip as a symbol name. Let me know if you prefer that.

@Twigz Twigz requested a review from lng-stripe October 28, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants