-
Couldn't load subscription status.
- Fork 694
[Identity] Adding in ISO, Exposure Duration, Focal Length, and isVirtualCamera to camera info #11819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pearapps
wants to merge
2
commits into
master
Choose a base branch
from
kpa/virtual-iso-exposure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APKDEX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the document capture camera info to include ISO, focal length, isVirtualCamera, and the exposure duration to the uploaded camera info. This matches the iOS implementation and parameters name.
While the name "Virtual Camera" might sound like a software camera - the definition used on iOS is whether or not the camera is a "multi camera" or something similar. This means that the camera is a composite of multiple physical cameras or uses multiple in some way.
I kept this definition for the field here.
Overall, this adds another field to the camera info into the parameters to further match the iOS parameters.
See these:
Or more succinctly, just the new params: