Remove unnecessary ConsumerPaymentDetails.Passthrough
#11652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: stripe-android-translations[bot] <150425582+stripe-android-translations[bot]@users.noreply.github.com>
* Use merchant publishable key for Link requests * Update tests * Inject API request options directly * Add clarifying comment for custom API keys * Use a provider * Recompute request options every time
3 tasks
* Add PromptPay support to Android payment element Implements PromptPay payment method following the same patterns as PayNow: **Payment Method Support (PR #11396 pattern):** - Add PromptPay to PaymentMethod.Type enum with code "promptpay" - Create PromptPayDefinition with feature flag support behind enablePromptPay - Add PromptPay drawable resources (day/night variants) - Update PaymentMethodRegistry to include PromptPay - Add PromptPay string resources and playground settings **Next Action Support (PR #11405 pattern):** - Add DisplayPromptPayDetails next action type with code "promptpay_display_qr_code" - Create DisplayPromptPayDetails data class with qrCodeUrl property - Update PaymentIntent, SetupIntent, and StripeIntentResult to handle PromptPay next actions - Add DisplayPromptPayDetailsJsonParser for parsing next action data - Update PaymentSheetNextActionHandlers to use PollingNextActionHandler for PromptPay - Add PromptPay polling configuration (1-hour time limit, 5-second initial delay) **Testing Support (PR #11511 pattern):** - Add TestPromptPay instrumentation test with Thailand (TH) country and Thai Baht (THB) currency - Add Thailand and Thai Baht to Country and Currency enums - Create EnablePromptPaySettingsDefinition for playground settings - Use ShowQrCodeThenPoll authorization action All changes maintain consistency with existing PayNow implementation patterns. Tests will pass once backend PromptPay support is implemented. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Committed-By-Agent: claude * Lint fixes * Update icons --------- Co-authored-by: Claude <noreply@anthropic.com>
|
Diffuse output: APKDEX |
tillh-stripe
force-pushed
the
tillh/remove-passthrough-consumerpaymentdetails-2
branch
from
eea98dd to
6c09b91
Compare
When using the payment sheet playground with a returning customer, attempting to checkout with a saved payment method resulted in an error: "The PaymentMethod <pm_id> does not belong to the Customer you supplied <cus_id>." The root cause was that the Android playground was always sending the string "returning" to the backend, even after a customer ID was created and stored. This fix adds a `backendParamValue` property to `CustomerType` that returns the actual customer ID for `Existing` type, or the type string for other types, matching the iOS behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Committed-By-Agent: claude Co-authored-by: Claude <noreply@anthropic.com>
tillh-stripe
force-pushed
the
tillh/remove-passthrough-consumerpaymentdetails-2
branch
3 times, most recently
from
91d18ee to
5dd3c56
Compare
* Fix returning customer checkout with saved payment methods When using the payment sheet playground with a returning customer, attempting to checkout with a saved payment method resulted in an error: "The PaymentMethod <pm_id> does not belong to the Customer you supplied <cus_id>." The root cause was that the Android playground was always sending the string "returning" to the backend, even after a customer ID was created and stored. This fix adds a `backendParamValue` property to `CustomerType` that returns the actual customer ID for `Existing` type, or the type string for other types, matching the iOS behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Committed-By-Agent: claude * Add duration tracking to PaymentLauncher analytics events Track duration from when confirm/next action starts until the finish analytics event is sent. Duration is included in the analytics params with key "duration" and value in milliseconds. Changes: - Add PaymentLauncher key to DurationProvider.Key enum - Inject DurationProvider in PaymentLauncherViewModel - Start tracking in confirmStripeIntent and handleNextActionForStripeIntent - Add duration param to PaymentLauncherConfirmFinished and PaymentLauncherNextActionFinished events - Add tests verifying duration is included in analytics 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Committed-By-Agent: claude * revert unnecessary changes, fix lint --------- Co-authored-by: Claude <noreply@anthropic.com>
Remove Google Pixel 3-9.0 from the nightly test device list as it is being deprecated by BrowserStack. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Committed-By-Agent: claude Co-authored-by: Claude <noreply@anthropic.com>
* Refactor NextStep * Refactor NextStep * Extract SharedPaymentTokenConfirmationInterceptor.kt * Extract DeferredIntentConfirmationInterceptor.kt * Extract IntentFirstConfirmationInterceptor.kt * Refactor with IntentConfirmationInterceptor.Factory * Fix tests * Add DefaultIntentConfirmationInterceptorFactoryTest * Minor fix * Update "waitFor" function call with elvis operator * Refactor methods * Inject confirmation interceptor factory * Inject requestOptions * Helper function for confirmation option and action * Fix tests * Refactor DefaultIntentConfirmationInterceptorTest * Address PR comments * Refactor DeferredIntentConfirmationInterceptorTest to not be a large class * Refactor SharedPaymentTokenConfirmationInterceptorTest to not have a long method * Shouldn't inherent DeferredIntentConfirmationInterceptorTest * Minor refactoring
* Setup playground * Refactor
* Migrate to Dokka 2.0 * Remove changes in `hcaptcha` module
* Update Link recollection UI * Show error on disabled primary button press
tillh-stripe
force-pushed
the
tillh/remove-passthrough-consumerpaymentdetails-2
branch
from
3b9a041 to
c5a0caf
Compare
Co-authored-by: stripe-android-translations[bot] <150425582+stripe-android-translations[bot]@users.noreply.github.com>
tillh-stripe
force-pushed
the
tillh/remove-passthrough-consumerpaymentdetails-2
branch
from
c5a0caf to
60c469d
Compare
tillh-stripe
force-pushed
the
tillh/remove-passthrough-consumerpaymentdetails-2
branch
from
60c469d to
aa19643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Screenshots
Changelog