fix: timer metrics unit #251
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Histograms are built using the default bucket definitions:
And
DefBucketsis:The timers were measuring values in milliseconds, whereas the underlying buckets are configured to store number as seconds.
I spotted the misconfiguration by checking the DNS resolution timers on our deployments: most of the timers are between 5 and 10 ms (to the last 2 buckets) and all the initial buckets are almost not used.
Changing to seconds instead of milliseconds would fill up in our case the first 2 or 3 buckets and show the higher latencies (if any) more correctly.