Fix incorrect type definition for onTaxCodeSelect #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgea-stripe
approved these changes
Apr 16, 2025
| @@ -692,7 +692,7 @@ export const ConnectProductTaxCodeSelector = ({ | |||
| disabled, | |||
| initialTaxCode | |||
| }: { | |||
| onTaxCodeSelect?: ({taxCode}: {taxCode: string}) => void; | |||
| onTaxCodeSelect?: (taxCode: string) => void; | |||
There was a problem hiding this comment.
Verified this matches the API review
There was a problem hiding this comment.
Also verified this is good in react: https://github.com/stripe/react-connect-js/blob/preview/src/Components.tsx#L695
|
@jorgea-stripe Thanks for the review! I'm waiting for the next preview release from connect-js to bump its version so the build would pass |
jorgea-stripe
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of the
onTaxCodeSelectprop was added incorrectly in #146.The approved type from API Review is
(taxCode: string) => void.