Create all CA secrets in parallel instead of chaining futures #11527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tinaselenge
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Create the CA secrets in parallel, rather than chaining the futures.
This will be needed in future for the cert-manager integration when we only create cert secrets and not key secrets, but also there is no reason to chain the futures since the Secrets can be created in any order.
Checklist
Please go through this checklist and make sure all applicable tasks have been done