-
Notifications
You must be signed in to change notification settings - Fork 1.4k
helm: Add unhealthyPodEvictionPolicy to PDB #11404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NOTE: this does not resolve #11403 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left one nit, but LGTM otherwise.
/azp run helm-acceptance |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Sorry but I need more clarifications about this ...
So what's the main purpose of this PR? You are adding what was proposed in #11403 but just for helm charts. Also by reading the Kubernetes doc it seems that the default (when no policy is specified) is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from just one nit, LGTM.
Updated to use |
/azp run helm-acceptance |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Type of change
Select the type of your PR
Description
Add support for
unhealthyPodEvictionPolicy
to helm for the operator.Checklist
Please go through this checklist and make sure all applicable tasks have been done