Skip to content

helm: Add unhealthyPodEvictionPolicy to PDB #11404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented May 2, 2025

Type of change

Select the type of your PR

  • Enhancement / new feature

Description

Add support for unhealthyPodEvictionPolicy to helm for the operator.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@jcpunk
Copy link
Contributor Author

jcpunk commented May 2, 2025

NOTE: this does not resolve #11403

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left one nit, but LGTM otherwise.

@scholzj
Copy link
Member

scholzj commented May 2, 2025

/azp run helm-acceptance

@scholzj scholzj added this to the 0.47.0 milestone May 2, 2025
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ppatierno
Copy link
Member

Sorry but I need more clarifications about this ...

NOTE: this does not resolve #11403

So what's the main purpose of this PR? You are adding what was proposed in #11403 but just for helm charts.

Also by reading the Kubernetes doc it seems that the default (when no policy is specified) is IfHealthyBudget while this PR related to helm charts uses the AlwaysAllow as default.

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from just one nit, LGTM.

@jcpunk
Copy link
Contributor Author

jcpunk commented May 6, 2025

Updated to use IfHealthyBudget as the default.

@scholzj
Copy link
Member

scholzj commented May 6, 2025

/azp run helm-acceptance

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ppatierno ppatierno merged commit 47ebbc5 into strimzi:main May 8, 2025
13 checks passed
@jcpunk jcpunk deleted the pdb branch May 9, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants