python_reader: correctly handle decorators and nested functions #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing nested functions as dot-separated makes sense as part of the general approach 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix issues #2275 and #2276.
reader_python.py's get_node_ns() is changed to walk up the tree and collect all identifiers along the way.
This should generate function names that are reasonnably unique and should work well as UIDs for the test report generation, for example:
ClassName.NestedClassName.method_name.nested_methodnameI am a bit concerned as this change invalidates unit test_02_functions(), which was specifically checking that nested functions are exported as flat functions (i.e. without their parent names). Therefore, I am unsure if my attempt at fixing this breaks something else...