docker: simplify setup #2179
docker: simplify setup #2179
Conversation
|
Hello 🙂 Thanks for looking into this not-so-optimal Docker setup and contributing improvements! The main driver for the existing Docker setup, as it is now, was to make the Google Chrome / Google Chrome Driver setup happy and make the HTML2PDF/html2print library runnable against it. I spent a considerable time tinkering with possible options, so there is some chance that you will have to fight some more to make everything work together your improvements. I see that your PR has more trivial improvements that could be merged separately from the actual functional change. Feel free to send them with a separate PR that should pass the tests easier. Having one PR is also fine, whatever is more convenient to you. |
Especially the user and group IDs can simply be passed into the Docker container without the need of an entrypoint script.
6arms1leg
force-pushed
the
fix/simplify-docker-setup
branch
from
eb945c6 to
63d81b8
Compare
|
Sorry, I overlooked the CI Docker tests! I verified it just using the "hello world" example from the documentation, which does not exercise the PDF generation. I will have another look ... |
|
OK, this Google Chrome Driver issue is really weird. I tried a few things to come up with a clean solution but unfortunately didn't manage to do so. Sorry! |
Thanks a lot for trying anyway. The current solution is not great but it works anyhow. I will revisit this if the future evolution requires it. |
This PR simplifies the Docker setup and updates the related documentation.
Especially the user and group IDs can simply be passed into the Docker container without the need of an entrypoint script.