Skip to content

feat: [FRONT-2099] support arbitrary hex strings for granting pubsub permissions on Hub #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hpihkala
Copy link
Contributor

@hpihkala hpihkala commented May 21, 2025

  • NewStreamPermissionsModal changes:
    • Allows the user to input any hex string instead of Ethereum address
    • However Grant, Edit, and Delete permission can only be given to Ethereum addresses
    • Some permissions must be checked for the submit button to be enabled
  • Copy changes on stream page to replace 'account' terminology with 'keys' or 'Public Key' terminology depending on context.
  • Fix overflow issue in case of long public keys (*screenshots below)
  • Unrelated fix: CI was broken due to trying to start no-longer-existing nginx service

(*) Before:

Screenshot 2025-05-21 at 16 57 58

After:

Screenshot 2025-05-21 at 16 58 08

Copy link

linear bot commented May 21, 2025

@hpihkala hpihkala requested review from tumppi and mondoreale May 21, 2025 15:55
Copy link
Collaborator

@mondoreale mondoreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good.

I am, for some post-software-update related reason, unable to fire up the hub (node-datachannel + node-gyp). Working on it.

Will test in the browser as soon as possible!

Copy link
Collaborator

@mondoreale mondoreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok., tested. Works well!

@mondoreale mondoreale merged commit a2d26e3 into master May 23, 2025
9 checks passed
@mondoreale mondoreale deleted the FRONT-2099/support-arbitrary-hex-strings-for-granting-pubsub-permissions-on-hub branch May 23, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants