feat(parent): Support strawberry.Parent with future annotations #3851

bellini666 · 2025-05-10T13:19:15Z

Fix #3481

This also makes #3714 not required

Summary by Sourcery

Add support for using strawberry.Parent with future annotations and delayed type evaluation

New Features:

Support using strawberry.Parent with forward references and future annotations

Enhancements:

Improve type resolution for Parent types in different annotation scenarios

Tests:

Add test cases for Parent type with future annotations and string-based type references

Chores:

Add a release note explaining the new Parent type annotation support

sourcery-ai · 2025-05-10T13:19:20Z

Reviewer's Guide

This pull request enables strawberry.Parent to work with future annotations (both from __future__ import annotations and string literals like "User"). This is primarily achieved by introducing resolve_parent_forward_arg in strawberry/parent.py to parse and correctly reconstruct Parent types using ForwardRef internally when a string or ForwardRef is detected as its argument. Consequently, eval_type in strawberry/utils/typing.py was updated to handle StrawberryParent instances, and the field resolver logic in strawberry/types/fields/resolver.py was modified to use the new parsing function to correctly identify Parent types with forward references. Error handling for NameError during argument type evaluation in strawberry/types/field.py was also improved to accommodate unevaluated forward references.

File-Level Changes

Change	Details	Files
Implemented support for future annotations in `strawberry.Parent`.	Introduced `resolve_parent_forward_arg` function to parse string/`ForwardRef` arguments within `Parent` annotations and re-wrap them with `ForwardRef`. Updated `eval_type` to correctly process and evaluate `StrawberryParent` instances. Modified field resolver to use `resolve_parent_forward_arg` for identifying `Parent` types with forward-referenced arguments.	`strawberry/parent.py` `strawberry/utils/typing.py` `strawberry/types/fields/resolver.py`
Enhanced robustness of field argument type evaluation.	Added `NameError` handling during argument type access to support forward references.	`strawberry/types/field.py`
Added comprehensive tests for the new `strawberry.Parent` functionality.	Created test suite for `strawberry.Parent` with `from __future__ import annotations`. Created test suite for `strawberry.Parent` with string literal type hints.	`tests/types/test_parent_type_future_annotations.py` `tests/types/test_parent_type.py`
Added release notes for the feature.	Documented the support for `strawberry.Parent` with future annotations.	`RELEASE.md`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#3481	Enable `strawberry.Parent` to work with forward references, allowing type hints to refer to types that are not yet defined.	✅
#3481	Update documentation to reflect the correct usage of `strawberry.Parent` with function resolvers, specifically addressing the `NameError` encountered when using forward references.	✅

Possibly linked issues

strawberry.Parent not supporting forward refs #3481: The PR adds support for strawberry.Parent with future annotations, fixing the type resolution error described in the issue.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

greptile-apps

PR Summary

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: https://app.greptile.com/review/github.

_{💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!}

_{7 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings | Greptile}

Copilot

Pull Request Overview

This PR introduces support for using strawberry.Parent with future annotations, addressing a previously reported issue and simplifying related annotation handling.

Added tests for both direct and string-based forward references using strawberry.Parent.
Updated type evaluation and resolver logic to gracefully handle strawberry.Parent types.
Introduced a new helper function resolve_parent_forward_arg in strawberry/parent.py.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/types/test_parent_type_future_annotations.py	Adds a test using future annotations with strawberry.Parent (e.g. Parent[User]).
tests/types/test_parent_type.py	Adds a test using string-based forward references with strawberry.Parent (e.g. Parent["User"]).
strawberry/utils/typing.py	Updates eval_type to handle StrawberryParent types by checking for instances and adjusting args.
strawberry/types/fields/resolver.py	Modifies forward reference evaluation to use resolve_parent_forward_arg when a NameError occurs.
strawberry/types/field.py	Refactors argument type evaluation to catch NameError and skip forward references.
strawberry/parent.py	Adds the helper function resolve_parent_forward_arg to support parsing strawberry.Parent annotations.
RELEASE.md	Updates release notes detailing support for strawberry.Parent with both future annotations and delayed evaluation.

botberry · 2025-05-10T13:21:10Z

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release adds support to use strawberry.Parent with future annotations.

For example, the following code will now work as intended:

from __future__ import annotations


def get_full_name(user: strawberry.Parent[User]) -> str:
    return f"{user.first_name} {user.last_name}"


@strawberry.type
class User:
    first_name: str
    last_name: str
    full_name: str = strawberry.field(resolver=get_full_name)


@strawberry.type
class Query:
    @strawberry.field
    def user(self) -> User:
        return User(first_name="John", last_name="Doe")


schema = strawberry.Schema(query=Query)

Or even when not using future annotations, but delaying the evaluation of User, like:

# Note the User being delayed by passing it as a string
def get_full_name(user: strawberry.Parent["User"]) -> str:
    return f"{user.first_name} {user.last_name}"


@strawberry.type
class User:
    first_name: str
    last_name: str
    full_name: str = strawberry.field(resolver=get_full_name)


@strawberry.type
class Query:
    @strawberry.field
    def user(self) -> User:
        return User(first_name="John", last_name="Doe")


schema = strawberry.Schema(query=Query)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

sourcery-ai

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

codecov · 2025-05-10T13:25:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (f6ac9bb) to head (81d9e36).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #3851    +/-   ##
========================================
  Coverage   95.04%   95.05%            
========================================
  Files         502      507     +5     
  Lines       32719    32931   +212     
  Branches     1696     1710    +14     
========================================
+ Hits        31098    31302   +204     
- Misses       1348     1355     +7     
- Partials      273      274     +1

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codspeed-hq · 2025-05-10T13:39:18Z

CodSpeed Performance Report

Merging #3851 will not alter performance

_{Comparing parent-forward-refs (81d9e36) with main (68d694e)}

Summary

✅ 21 untouched benchmarks

Fix #3481

strawberry/types/fields/resolver.py

bellini666 requested a review from patrick91 May 10, 2025 13:19

greptile-apps bot reviewed May 10, 2025

View reviewed changes

bellini666 requested a review from Copilot May 10, 2025 13:19

Copilot AI reviewed May 10, 2025

View reviewed changes

bellini666 force-pushed the parent-forward-refs branch from 6e2d70a to e75995b Compare May 10, 2025 13:20

botberry added bot:has-release-file labels May 10, 2025

bellini666 mentioned this pull request May 10, 2025

Update accessing parent data guide with lazy type declaration #3714

Closed

11 tasks

sourcery-ai bot reviewed May 10, 2025

View reviewed changes

bellini666 force-pushed the parent-forward-refs branch from e75995b to b497961 Compare May 10, 2025 13:25

feat(parent): Support strawberry.Parent with future annotations

d2abf06

Fix #3481

bellini666 force-pushed the parent-forward-refs branch from b497961 to d2abf06 Compare May 10, 2025 13:48

patrick91 approved these changes May 10, 2025

View reviewed changes

strawberry/types/fields/resolver.py Outdated Show resolved Hide resolved

Update strawberry/types/fields/resolver.py

81d9e36

bellini666 merged commit 0a217e8 into main May 10, 2025
103 checks passed

bellini666 deleted the parent-forward-refs branch May 10, 2025 15:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(parent): Support strawberry.Parent with future annotations #3851

feat(parent): Support strawberry.Parent with future annotations #3851

Uh oh!

bellini666 commented May 10, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented May 10, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

greptile-apps bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

botberry commented May 10, 2025 •

edited

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

codecov bot commented May 10, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented May 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat(parent): Support strawberry.Parent with future annotations #3851

feat(parent): Support strawberry.Parent with future annotations #3851

Uh oh!

Conversation

bellini666 commented May 10, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

botberry commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #3851 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bellini666 commented May 10, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented May 10, 2025 •

edited

Loading

botberry commented May 10, 2025 •

edited

Loading

codecov bot commented May 10, 2025 •

edited

Loading

codspeed-hq bot commented May 10, 2025 •

edited

Loading