-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Expand and improve Client docs #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Clearer examples and addition of error message if baseURL is missing protocol
Added note that this is the only auth method currently; added error message
Standardising with rest of docs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this your first Strapi PR?! 🎉
I gave it a quick look but haven't tested the code examples yet
ac6cd23
to
edd788d
Compare
This reverts commit edd788d.
Hey @hanpaine! Congrats on your very first docs PR! It's already great 🫶 However, upon further inspection 👀 , it seems I need to do a deeper rewrite. Because what's new is actually adding the So I will largely reorganize the content, for consistency and clarity. Thank you very much again for your base work, it's really helpful! 👏 |
so that the new upload-related information better fits with the existing information architecture
@hanpaine I finished rewriting the PR content so it better fits with the existing information architecture. (The only thing that's bugging me is that it's using "ids" in code examples. I thought we switched to |
Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com>
Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com>
U&P is usable now (but still not documented here)
What does it do?
** note this documentation was created with the help of Dosu :)
Why is it needed?
Documentation for media upload is currently missing from Strapi docs.
Related issue(s)/PR(s)
strapi/client#92