-
Notifications
You must be signed in to change notification settings - Fork 36
fix: Prevent exported runtime stories from colliding with story names #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've confirmed that the failing test is indeed because Storybook's internal CSF parsing (that is used by the Vitest addon) has a bug where it does not get tags (like Thus making this change would mean that story-level |
We could patch the fix back to 8.6 if it helps? I'm doing an RC release in the next hour also FWIW |
The addon supports 8.2 and up, so that wouldn't help that much in terms of breaking change. I think waiting till 9.0 GA is fine. |
I updated the Storybook (and a bunch of other stuff) to include the fix and now the tests are passing. 🎉 |
Resolves #250