fix(lib): global styles get re-enabled when useFieldPlugin is called multiple times #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
useFieldPlugincallscreateFieldPlugin, which disabled the global styles as a side effect. It also attempts to clean up the side effect by enabling the style sheet again. This means that when a component that callsuseFieldPluginunmounts, the cleanup function enables the style sheet again. But this causes an issue if there is still another component that was using this side effect:useFieldPlugin. The style sheet gets disabled.useFieldPlugin. The style sheet remains disabled.Originally,
createFieldPluginwas not meant to be called more than once: you were supposed to pass the state and methods via context or props.As a solution, I think we can simply skip removing the
disabledattribute from thestyleelement,How to test? (optional)