-
Notifications
You must be signed in to change notification settings - Fork 3
Add defmt #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add defmt #41
Conversation
@@ -1,8 +1,9 @@ | |||
[target.thumbv8m.main-none-eabihf] | |||
runner = 'arm-none-eabi-gdb' | |||
runner = 'probe-rs run --connect-under-reset' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something you want?
How to run defmt with probe-rs:
DEFMT_LOG=trace cargo r --features stm32h503,defmt --example blinky -- --chip stm32h503RETx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. The private fork we use is using probe-rs, so happy to have this change
Cargo.toml
Outdated
@@ -83,4 +85,4 @@ opt-level = "s" # optimize for binary size | |||
|
|||
[[example]] | |||
name = "blinky" | |||
required-features = ["stm32h503"] | |||
#required-features = ["stm32h503"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this requirement because the example was written for the H503 nucleo board. If its the same pin assignment on other nucleo boards we can remove the feature, or add different pin assignments for different boards, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Adding |
@@ -21,7 +21,7 @@ jobs: | |||
- stm32h563 | |||
- stm32h573 | |||
env: # Peripheral Feature flags | |||
FLAGS: rt,log | |||
FLAGS: rt,log,defmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astapleton should defmt/log be its own dimension in the matrix here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rt should always be set, so I would keep that in the env
configuration and have a separate matrix for log/defmt. And wouldn't log
and defmt
be mutually exclusive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, updated
No description provided.