generic GPIO #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

usbalbin merged 4 commits into stm32-rs:main from burrbull:gpio-generic

May 30, 2025

Member

burrbull commented May 28, 2025

Part 3 of #186

burrbull force-pushed the gpio-generic branch from a1700d8 to a16930d Compare

May 28, 2025 13:33


          generic Pins

eaa3721

burrbull force-pushed the gpio-generic branch from a16930d to eaa3721 Compare

May 28, 2025 15:43


          fix DAC

e308103

burrbull force-pushed the gpio-generic branch from dcbbe44 to e308103 Compare

May 28, 2025 16:38


          Move dac test so it can check using other pin

e2791a6

burrbull marked this pull request as ready for review

May 29, 2025 08:30

usbalbin reviewed

View reviewed changes

src/gpio.rs Outdated Show resolved Hide resolved

usbalbin reviewed

View reviewed changes

src/gpio/erased.rs Outdated Show resolved Hide resolved

usbalbin reviewed

View reviewed changes

src/gpio/erased.rs Outdated Show resolved Hide resolved

usbalbin reviewed

View reviewed changes

src/gpio/erased.rs Outdated Show resolved Hide resolved

usbalbin reviewed

View reviewed changes

src/gpio/erased.rs Outdated Show resolved Hide resolved

usbalbin reviewed

View reviewed changes

src/gpio/g4.rs Show resolved Hide resolved

usbalbin reviewed

View reviewed changes

src/gpio/outport.rs

+              out_port!(OutPort5 => 5, (0, 1, 2, 3, 4), (N0, N1, N2, N3, N4));
+              out_port!(OutPort6 => 6, (0, 1, 2, 3, 4, 5), (N0, N1, N2, N3, N4, N5));
+              out_port!(OutPort7 => 7, (0, 1, 2, 3, 4, 5, 6), (N0, N1, N2, N3, N4, N5, N6));
+              out_port!(OutPort8 => 8, (0, 1, 2, 3, 4, 5, 6, 7), (N0, N1, N2, N3, N4, N5, N6, N7));

Member

usbalbin May 29, 2025

Wow, interesting!

usbalbin reviewed

View reviewed changes

src/gpio/partially_erased.rs Outdated Show resolved Hide resolved

usbalbin reviewed

View reviewed changes

src/gpio/partially_erased.rs Outdated Show resolved Hide resolved

usbalbin reviewed

View reviewed changes

src/gpio/exti.rs

+                  #[inline(always)]
+                  fn check_interrupt(&self) -> bool {
+                      unsafe { ((*EXTI::ptr()).pr1().read().bits() & (1 << self.pin_id())) != 0 }

Member

usbalbin May 29, 2025

Are any of these arrayified?

Member Author

burrbull May 29, 2025

Unfortunately not. G4 has holes in fields there. https://stm32-rs.github.io/stm32-rs/STM32G474.html#EXTI


          erasedpin -> anypin

04ad2da

burrbull force-pushed the gpio-generic branch from eb68754 to 04ad2da Compare

May 29, 2025 18:09

Member

usbalbin commented May 29, 2025

I ran the (not very extensive) test suite and it passed all tests for what it's worth

usbalbin approved these changes

View reviewed changes

Member

usbalbin left a comment

This is really nice stuff! Thank you :)

Can I merge this now?

Member Author

burrbull commented May 30, 2025

Can I merge this now?

As you wish.

usbalbin added this pull request to the merge queue

Merged via the queue into stm32-rs:main with commit 5308cce

34 checks passed

Member

usbalbin commented May 30, 2025

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet