-
Notifications
You must be signed in to change notification settings - Fork 49
Upgrade smoltcp to 0.12.0 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade smoltcp to 0.12.0 #99
Conversation
Hi and thanks for the contribution! Have you tested that all of this works as expected (i.e. ran the examples on some microcontroller)? |
Additionally: if you would be so kind to add an entry to the changelog, and bump the version of |
I've successfully executed |
Sure, I could do that! Do you mean to bump the version + update changelog in a separate PR? |
Excellent, that sounds good enough for me.
Great :) No, same PR is fine, just so long as they are separate commits, one for changelog, one for version bump. (I won't squash them, so we'll retain nice history on the master branch). Linking to the as-of-yet-nonexistent v0.8.0 tag in the changelog header is fine, I will add it ASAP. |
7d7d544
to
4b1cb72
Compare
Thanks again for your contribution :) v0.8.0 is now available. |
@datdenkikniet: Thank you for your help and very quick response! |
Description
Smoltcp updated to version 0.12.0. Examples fixed correspondingly.
TODO