[Security Issue] Apply secure_filename to snapshot_path for security hardening

[shyun020]

Description

• Security fix – Resolved a path injection vulnerability in the snapshot_path parameter.

This change uses secure_filename from werkzeug.utils to sanitize the snapshot_path value obtained from user input, preventing malicious path traversal or unauthorized file access.

Problem

Previously, the snapshot_path parameter was used without validation. An attacker could exploit this by passing values like ../../etc/passwd, potentially gaining access to sensitive files on the server. This posed a serious path injection security risk.

Code Change

from werkzeug.utils import secure_filename

snapshot_path = secure_filename(request.args.get("snapshot_path"))

The secure_filename function ensures the input is converted to a safe, valid filename, effectively blocking directory traversal attempts.

Test Plan

• Attempted path injection using snapshot_path=../../etc/passwd
• Before fix: Able to access unintended paths
• After fix: Filename is sanitized (e.g., becomes etc_passwd), preventing unauthorized access

[shyun020]

@ARajgor I'd appreciate it if you could review the unit tests I wrote 🙏

[shyun020]

@ARajgor

knock knock

[shyun020]

@ARajgor

knock knock

[shyun020]

@Seagh0098

knock knock

[shyun020]

@Seagh0098

knock knock

[rohanod]

@Seagh0098

knock knock

How mature

[shyun020]

@Seagh0098
knock knock

How mature

Why so serious? 😏

[shyun020]

May I ask how long it will take for the final merge? Also, has the CI process been completed?

@Seagh0098