get client id and secret from parameter store #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Github action deployment is going to have to be altered to allow this as there are new variables needed to be inputed. |
is that a trouble or some huge change on current code? we can also just store that in the parameter store manually as only one day left |
|
OK I'v altered the deploy action so it will pull the repo secrets GIT_HUB_CLIENT_ID and GIT_HUB_CLIENT_SECRET and input it into the terraform |
|
cool |
terraform/main/rsakey.tf
Outdated
| } | ||
|
|
||
| resource "aws_ssm_parameter" "client_id" { | ||
| name = "client_id" |
There was a problem hiding this comment.
need the deployment id for all of these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.