You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@briwylde08 Do the notes make sense? I'm sure there are ways they could be reworded or cleaned up, especially the ones that are like "never used i think" lol. Does this chunk of text make sense on the page? In the specific place I have it? Or, should we move it?
@dmkozh I searched in that repo for occurrences of ContractError::ErrorNameHere and tried my best to make sense of what I was seeing. Did I capture correctly what each one is doing? What's the best way to handle the "never used" errors?
The only place I found this error being thrown is in the SAC's balance.rs file. The function read_trustline_entry(...) similarly appears to be used only in that file. Mostly appears to do with balance operations (duh lol)? The functions that make use of the read_trustline_entry function are named get_trustline_balance, transfer_trustline_balance, get_trustline_flags, and set_trustline_authorization.
Not sure of a succinct way to incorporate that into the description, though.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've copied the contract errors from the built-in contracts crate.
Questions for specific people:
@briwylde08 Do the notes make sense? I'm sure there are ways they could be reworded or cleaned up, especially the ones that are like "never used i think" lol. Does this chunk of text make sense on the page? In the specific place I have it? Or, should we move it?
@dmkozh I searched in that repo for occurrences of
ContractError::ErrorNameHereand tried my best to make sense of what I was seeing. Did I capture correctly what each one is doing? What's the best way to handle the "never used" errors?refs: #1499