-
Notifications
You must be signed in to change notification settings - Fork 82
Migrate to Devcontainers POC #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻 Few comments inline.
…o/.cargo/bin:/opt/homebrew/opt/ruby/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/usr/local/munki:/Users/chris.anatalio/.cargo/bin:/Users/chris.anatalio/Library/Application Support/JetBrains/Toolbox/scripts:/Users/chris.anatalio/.rvm/bin
If you prefer to do it this way, I think it's reasonable to add the prebuilds in a follow up so that this can get merged and in use. Even if it's a bit slower to boot. |
…o/.cargo/bin:/opt/homebrew/opt/ruby/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/usr/local/munki:/Users/chris.anatalio/.cargo/bin:/Users/chris.anatalio/Library/Application Support/JetBrains/Toolbox/scripts:/Users/chris.anatalio/.rvm/bin
Signed-off-by: chris.anatalio <chris.anatalio@stellar.org>
Signed-off-by: chris.anatalio <chris.anatalio@stellar.org>
ADDED Devcontainer GH Actions
Only runs on changes to |
One issue I noticed is that |
Reviewed devcontainers setup with Copilot ✅ |
Tested:
Output ✅
|
Signed-off-by: chris.anatalio <chris.anatalio@stellar.org>
Signed-off-by: chris.anatalio <chris.anatalio@stellar.org>
Signed-off-by: chris.anatalio <chris.anatalio@stellar.org> Build stellar cli and sccache from gh release binary Signed-off-by: chris.anatalio <chris.anatalio@stellar.org> Build stellar cli and sccache from gh release binary Signed-off-by: chris.anatalio <chris.anatalio@stellar.org> Build stellar cli and sccache from gh release binary Signed-off-by: chris.anatalio <chris.anatalio@stellar.org> Build stellar cli and sccache from gh release binary Signed-off-by: chris.anatalio <chris.anatalio@stellar.org> Fix bash script tests Signed-off-by: chris.anatalio <chris.anatalio@stellar.org> Improve schema validation error msgs Signed-off-by: chris.anatalio <chris.anatalio@stellar.org> Cleanup Signed-off-by: chris.anatalio <chris.anatalio@stellar.org>
Signed-off-by: chris.anatalio <chris.anatalio@stellar.org>
Signed-off-by: chris.anatalio <chris.anatalio@stellar.org>
Signed-off-by: chris.anatalio <chris.anatalio@stellar.org>
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
…soroban-examples into migrate-to-devcontainers-poc
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
Signed-off-by: Chris.Anatalio <chris.anatalio@stellar.org>
What
Migrated to Devcontainers!
I documented the changes in
devcontainer.md
and gave an intro to devcontainers in general.So there are 2 main ways to engage with devcontainers:
In addition:
ADDED: Github Actions CI Pipeline Workflows
DX:
make all
script should be workingWhy
Gitpod EOL and devcontainers are way better
Known limitations
make all
fills up the 32GB disk so I may have to do some optimization there.HOW
Testing steps
https://codespaces.new/stellar/soroban-examples/tree/migrate-to-devcontainers-poc
Make sure branch

migrate-to-devcontainers-poc
is chosencd to desired contract -> make all(build -> test)
Or:
Test cache: